[Mesa-dev] [PATCH 1/4] intel/decoder: Drop gen_field_decode helper

[Lionel Landwerlin]

I was using it in the aubinator ui, but that's kind of stalled a bit.
I'm fine adding it back later if people are still interested in the UI.

This series is :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 13/12/17 01:38, Jason Ekstrand wrote:
> It's unused
> ---
>   src/intel/common/gen_decoder.c | 8 --------
>   src/intel/common/gen_decoder.h | 3 ---
>   2 files changed, 11 deletions(-)
>
> diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c
> index b3501ae..9f4f503 100644
> --- a/src/intel/common/gen_decoder.c
> +++ b/src/intel/common/gen_decoder.c
> @@ -1011,14 +1011,6 @@ gen_field_is_header(struct gen_field *field)
>      return (field->parent->opcode_mask & bits) != 0;
>   }
>   
> -void gen_field_decode(struct gen_field *field,
> -                      const uint32_t *p, const uint32_t *end,
> -                      union gen_field_value *value)
> -{
> -   uint32_t dword = field->start / 32;
> -   value->u64 = iter_decode_field_raw(field, &p[dword], end);
> -}
> -
>   void
>   gen_print_group(FILE *outfile, struct gen_group *group,
>                   uint64_t offset, const uint32_t *p, bool color)
> diff --git a/src/intel/common/gen_decoder.h b/src/intel/common/gen_decoder.h
> index 8b00b6e..bf7cb42 100644
> --- a/src/intel/common/gen_decoder.h
> +++ b/src/intel/common/gen_decoder.h
> @@ -62,9 +62,6 @@ struct gen_field *gen_group_find_field(struct gen_group *group, const char *name
>   struct gen_enum *gen_spec_find_enum(struct gen_spec *spec, const char *name);
>   
>   bool gen_field_is_header(struct gen_field *field);
> -void gen_field_decode(struct gen_field *field,
> -                      const uint32_t *p, const uint32_t *end,
> -                      union gen_field_value *value);
>   
>   struct gen_field_iterator {
>      struct gen_group *group;