[Mesa-dev] [PATCH] isl: Don't require VALIGN_2 for R32G32B32_FLOAT on Haswell.

[Jason Ekstrand]

Fine with me

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Thu, Dec 14, 2017 at 4:56 PM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> According to the RENDER_SURFACE_STATE internal documentation, the
> R32G32B32_FLOAT restriction is marked "IVB" only.  We choose to apply
> it to Ivybridge and Baytrail, but not Haswell.
>
> Fixes KHR-GL46.texture_size_promotion.functional on Haswell.
>
> Changes these tests from crashing to skipping on Haswell:
> - KHR-GL46.direct_state_access.textures_storage_multisample_2d_rgb32f
> - KHR-GL46.direct_state_access.textures_storage_multisample_3d_rgb32f
> ---
>  src/intel/isl/isl_gen7.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/isl/isl_gen7.c b/src/intel/isl/isl_gen7.c
> index c42428cba7a..4fa9851233f 100644
> --- a/src/intel/isl/isl_gen7.c
> +++ b/src/intel/isl/isl_gen7.c
> @@ -38,9 +38,11 @@ gen7_format_needs_valign2(const struct isl_device *dev,
>      *      (0x190)
>      *
>      *    - VALIGN_4 is not supported for surface format R32G32B32_FLOAT.
> +    *
> +    * The R32G32B32_FLOAT restriction is dropped on Haswell.
>      */
>     return isl_format_is_yuv(format) ||
> -          format == ISL_FORMAT_R32G32B32_FLOAT;
> +          (format == ISL_FORMAT_R32G32B32_FLOAT &&
> !ISL_DEV_IS_HASWELL(dev));
>  }
>
>  bool
> --
> 2.15.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171214/dfc4fe4b/attachment.html>