[Mesa-dev] [PATCH] travis: use LLVM 5.0 for Meson Vulkan

Emil Velikov emil.l.velikov at gmail.com
Fri Dec 15 17:35:03 UTC 2017


On 15 December 2017 at 16:49, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Friday, 2017-12-15 17:17:55 +0100, Juan A. Suarez Romero wrote:
>> Travis CI has moved to LLVM 5.0, and meson is detecting automatically
>> the available version.
>>
>> So just let's change to LLVM 5.0 for this case.
>
> I thought we were using 3.9 on purpose, to test our minimum required
> llvm version?
>
> I think the proper fix would be to add a `-D llvm-version=3.9` option
> and use that in the dependency() check.
>
Allow me to suggest and alternative solution:

Feed in the llvm-config name (aka LLVM_CONFIG) like we do for scons
and autotools.
It will provide some nice consistency, plus it will allow for easier
selection as path and version.

Not to mention that distributions (Debian for example) allow multiple
versions to coexist, naming the binary - llvm-config-$version.

-Emil


More information about the mesa-dev mailing list