[Mesa-dev] [PATCH] travis: use LLVM 5.0 for Meson Vulkan

Juan A. Suarez Romero jasuarez at igalia.com
Mon Dec 18 13:04:58 UTC 2017


On Fri, 2017-12-15 at 18:49 +0100, Gert Wollny wrote:
> Am Freitag, den 15.12.2017, 17:17 +0100 schrieb Juan A. Suarez Romero:
> > Travis CI has moved to LLVM 5.0, and meson is detecting automatically
> > the available version.
> 
> Considering that LLVM 5.0 is obviously not properly made available in
> the travis-ci environment, I've reported the problem with travis-
> upstream: 
> 
> https://github.com/travis-ci/travis-ci/issues/8925
> 
> Apart from that I think Eric is right, one should be able to specify
> the version instead of just taking the latest availabe version. The
> autotools based builds all force a version, which helps work around the
> other problem:  
> 

I agree too. Either if there's an issue in Travis with LLVM, I also
think it is a good idea to allow meson to specify LLVM version to use.

As Emil said, several distributions allow to have several versions, so
it would be good to allow to choose which one to use.


> The travis version of LLVM is in /usr/local, so it is definitely not a
> packaged version, since this would go into /usr, and because the PATH
> defines /usr/local/bin before /usr/bin, and the local (incomplete)
> version takes precedence, so adding llvm-5.0-dev like this is probably
> useless.
> 
> Gallium ST Clover with LLVM-5.0 passes because it uses the package
> version by specifically picking llvm-config-5.0 which, as Emil pointed
> out, is a Debian+derivatives feat.
> 
> Best, 
> Gert
> 
> > 
> > So just let's change to LLVM 5.0 for this case.
> > ---
> >  .travis.yml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/.travis.yml b/.travis.yml
> > index 211df3ec1ef..20432361176 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -37,12 +37,12 @@ matrix:
> >        addons:
> >          apt:
> >            sources:
> > -            - llvm-toolchain-trusty-3.9
> > +            - llvm-toolchain-trusty-5.0
> >            packages:
> >              # LLVM packaging is broken and misses these dependencies
> >              - libedit-dev
> >              # From sources above
> > -            - llvm-3.9-dev
> > +            - llvm-5.0-dev
> >              # Common
> >              - xz-utils
> >              - libexpat1-dev
> 
> 


More information about the mesa-dev mailing list