[Mesa-dev] [PATCH] anv: disallow VK_REMAINING_ARRAY_LAYERS in vkCmdClearAttachments()

[Jason Ekstrand]

Rb


On December 19, 2017 04:24:48 Samuel Iglesias Gonsálvez 
<siglesias at igalia.com> wrote:

> Vulkan spec doesn't specify that VK_REMAINING_ARRAY_LAYERS is allowed
> in the passed VkClearRect struct.
>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> ---
>  src/intel/vulkan/anv_blorp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index e244468e03b..8bb0216d6e4 100644
> --- a/src/intel/vulkan/anv_blorp.c
> +++ b/src/intel/vulkan/anv_blorp.c
> @@ -989,6 +989,7 @@ clear_color_attachment(struct anv_cmd_buffer *cmd_buffer,
>     for (uint32_t r = 0; r < rectCount; ++r) {
>        const VkOffset2D offset = pRects[r].rect.offset;
>        const VkExtent2D extent = pRects[r].rect.extent;
> +      assert(pRects[r].layerCount != VK_REMAINING_ARRAY_LAYERS);
>        blorp_clear_attachments(batch, binding_table,
>                                ISL_FORMAT_UNSUPPORTED, pass_att->samples,
>                                pRects[r].baseArrayLayer,
> @@ -1060,6 +1061,7 @@ clear_depth_stencil_attachment(struct anv_cmd_buffer 
> *cmd_buffer,
>        const VkOffset2D offset = pRects[r].rect.offset;
>        const VkExtent2D extent = pRects[r].rect.extent;
>        VkClearDepthStencilValue value = attachment->clearValue.depthStencil;
> +      assert(pRects[r].layerCount != VK_REMAINING_ARRAY_LAYERS);
>        blorp_clear_attachments(batch, binding_table,
>                                depth_format, pass_att->samples,
>                                pRects[r].baseArrayLayer,
> --
> 2.15.1
>