[Mesa-dev] [PATCH] spirv: consider bitsize when handling OpSwitch cases

Jason Ekstrand jason at jlekstrand.net
Wed Dec 20 19:39:49 UTC 2017


On December 20, 2017 09:53:13 Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 19 December 2017 at 18:05, Juan A. Suarez Romero <jasuarez at igalia.com> 
> wrote:
>> When walking over all the cases in a OpSwitch, take in account the bitsize
>> of the literals to avoid getting wrong cases.
>
> Even if there's no obvious tests that this fixes a stable and/or fixes
> tag will be a good idea.

Unfortunately, the patches this one depends on are rather invasive so I 
didn't cc those to stable.  Also, we have yet to see a 64-bit switch 
anywhere other than the tests which were written because someone found the 
issue in our driver by inspection.  I highly doubt this will be a real 
problem for anyone.

--Jason.




More information about the mesa-dev mailing list