[Mesa-dev] [PATCH 04/12] spirv: Add SubgroupBallotKHR capability to SubgroupSize and SubgroupLocalInvocationId
Eduardo Lima Mitev
elima at igalia.com
Mon Dec 25 20:15:20 UTC 2017
Patches 1 to 4 are:
Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>
On 11/21/2017 02:24 AM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> The SPV_KHR_shader_ballot spec says:
>
> (Add the SubgroupBallotKHR capability to SubgroupSize.)
>
> (Add the SubgroupBallotKHR capability to SubgroupLocalInvocationId.)
>
> Yet the annotations are missing from the JSON. See also
> https://github.com/KhronosGroup/SPIRV-Headers/issues/44.
> ---
> src/compiler/spirv/spirv.core.grammar.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/compiler/spirv/spirv.core.grammar.json b/src/compiler/spirv/spirv.core.grammar.json
> index 9a9b903..67903d5 100644
> --- a/src/compiler/spirv/spirv.core.grammar.json
> +++ b/src/compiler/spirv/spirv.core.grammar.json
> @@ -5210,7 +5210,7 @@
> {
> "enumerant" : "SubgroupSize",
> "value" : 36,
> - "capabilities" : [ "Kernel" ]
> + "capabilities" : [ "Kernel", "SubgroupBallotKHR" ]
> },
> {
> "enumerant" : "SubgroupMaxSize",
> @@ -5235,7 +5235,7 @@
> {
> "enumerant" : "SubgroupLocalInvocationId",
> "value" : 41,
> - "capabilities" : [ "Kernel" ]
> + "capabilities" : [ "Kernel", "SubgroupBallotKHR" ]
> },
> {
> "enumerant" : "VertexIndex",
More information about the mesa-dev
mailing list