[Mesa-dev] [PATCH] radv: fix events on compute queues.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu Dec 28 08:12:32 UTC 2017


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Thu, Dec 28, 2017 at 7:29 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> The event emission wasn't sending the correct packet for gfx8 compute
> queues, which explains why it works on vega fine.
>
> This fixes the mpv vulkan hang.
>
> Fixes: ad61eac250 (radv: factor out eop event writing code. (v2))
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 6a89d4e568..42468bceed 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -4002,7 +4002,7 @@ static void write_event(struct radv_cmd_buffer *cmd_buffer,
>         si_cs_emit_write_event_eop(cs,
>                                    cmd_buffer->state.predicating,
>                                    cmd_buffer->device->physical_device->rad_info.chip_class,
> -                                  false,
> +                                  radv_cmd_buffer_uses_mec(cmd_buffer),
>                                    V_028A90_BOTTOM_OF_PIPE_TS, 0,
>                                    1, va, 2, value);
>
> --
> 2.14.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list