[Mesa-dev] [PATCH] radv: fix pipeline statistics end query on compute queue

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu Dec 28 08:12:49 UTC 2017


Please add a fixes tag.

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Thu, Dec 28, 2017 at 7:33 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> It's legal to a pipeline stat query on a compute queue,
> but we'd emit the wrong packet here. This should fix it to emit
> the correct packet.
>
> Noticed while inspecting the mpv hang.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_query.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
> index 5dc88af8f8..ace745e4e6 100644
> --- a/src/amd/vulkan/radv_query.c
> +++ b/src/amd/vulkan/radv_query.c
> @@ -1156,7 +1156,7 @@ void radv_CmdEndQuery(
>                 si_cs_emit_write_event_eop(cs,
>                                            false,
>                                            cmd_buffer->device->physical_device->rad_info.chip_class,
> -                                          false,
> +                                          radv_cmd_buffer_uses_mec(cmd_buffer),
>                                            V_028A90_BOTTOM_OF_PIPE_TS, 0,
>                                            1, avail_va, 0, 1);
>                 break;
> --
> 2.14.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list