[Mesa-dev] [PATCH 0/6] r600g/state_trackers small cleanups

Konstantin Kharlamov Hi-Angel at yandex.ru
Fri Dec 29 05:47:01 UTC 2017


I forgot to tell: there's actually lots of warnings for Wsign-compare, so if anybody wanted, it's something to look at. I fixed only as much of the code as I had a mood for :Ь

В письме от пятница, 29 декабря 2017 г. 8:32:26 MSK пользователь Konstantin Kharlamov написал:
> Mostly a quick run with -Wsign-compare. I didn't see any real problems
> though except for the changes at r600_isa.c where a unsigned been
> compared with -1.
> 
> No changes in piglit except for two unstable tests for me: dlist and
> multiple-texture-reading.
> 
> Regarding how did I manage to run piglit given it hangs r600g: well, it
> hangs in the very end on the same test, and really saves the results. So
> even though piglit run requires me to reboot in the end, it still gives
> most of results, except for, maybe, some dozens in the end.
> 
> P.S. I don't have commit rights.
> 
> Konstantin Kharlamov (6):
>   r600g: do not use "fast-clear" for small textures
>   r600g: constify some variables
>   nine: constify some variables
>   st/glx: constify some variables
>   r600g: some -Wsign-compare fixes
>   r600g: fix unused variable warning
> 
>  src/gallium/drivers/r600/cayman_msaa.c            |  2 +-
>  src/gallium/drivers/r600/eg_debug.c               |  6 +++---
>  src/gallium/drivers/r600/evergreen_state.c        |  8 ++++----
>  src/gallium/drivers/r600/r600_isa.c               |  6 +++---
>  src/gallium/drivers/r600/r600_pipe.h              |  2 +-
>  src/gallium/drivers/r600/r600_query.c             |  2 +-
>  src/gallium/drivers/r600/r600_state.c             | 12 ++++++------
>  src/gallium/drivers/r600/r600_state_common.c      |  6 ++----
>  src/gallium/drivers/r600/r600_test_dma.c          |  2 +-
>  src/gallium/drivers/r600/r600_texture.c           | 10 ++++++++++
>  src/gallium/drivers/r600/sb/sb_expr.cpp           |  2 +-
>  src/gallium/state_trackers/glx/xlib/glx_getproc.c |  2 +-
>  src/gallium/state_trackers/nine/nine_pipe.h       |  2 +-
>  src/gallium/state_trackers/nine/nine_shader.c     | 10 +++++-----
>  14 files changed, 40 insertions(+), 32 deletions(-)
> 
> 






More information about the mesa-dev mailing list