[Mesa-dev] [PATCH 3/4 v2] configure.ac: Separate HAVE_LLVM defines for gallium and radv

[Emil Velikov]

On 28 January 2017 at 14:04, Tobias Droste <tdroste at gmx.de> wrote:
> Only define HAVE_LLVM if --enable-gallium-llvm is provided.
> If radv is built add HAVE_LLVM_RADV define with the same value
> as HAVE_LLVM.
>
Barring any objections I'll add a bit more meat to this

"
Currently --enable-gallium-llvm is equivalent to HAVE_LLVM. At the
same time, non-gallium users such as radv do not require anything from
gallium (let alone the llvm code), thus they do not depend on it. One
option is to rename the gallium define to HAVE_GALLIUM_LLVM but that
was deemed too fragile/other [1] so lets use another define for radv.

Only define...
...

In the future we might rework --enable-gallium-llvm to --enable-llvm
as a generic guard/toggle. That can lead to small changes in some
extremely corner cases (like --disable-gallium-llvm
--with-vulkan-drivers=radeon) so let's keep it out for now.
[1] https://lists.freedesktop.org/archives/mesa-dev/2017-January/141897.html
"

That said, I'm testing the series for the following build
systems/combinations and if things are fine I'll merge the lot.
 - autoconf - {enable,disable}-gallium-llvm + --with-vulkan-drivers={radeon,}
 - scons - linux
 - scons - mingw64
 - scons msvc (appveyor)

The Android side ought to be fine, but I'm short on build setup for that one.
Emil