[Mesa-dev] [PATCH v4] i965: Prevent coverity warning

Eric Engestrom eric.engestrom at imgtec.com
Wed Feb 1 17:20:54 UTC 2017


On Wednesday, 2017-02-01 11:24:39 -0500, Robert Foss wrote:
> Add assert checking that num_sources is never larger than 3.
> 
> This prevents Coverity from concluding that the unhandled
> cases of num_sources not being 0-3 are relevant.
> 
> Coverity-Id: 1399480-1399489
> Signed-off-by: Robert Foss <robert.foss at collabora.com>
> Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
> Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

Pushed, thanks :)

> ---
>  src/mesa/drivers/dri/i965/brw_eu_validate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_eu_validate.c b/src/mesa/drivers/dri/i965/brw_eu_validate.c
> index 226539445d..64615af44a 100644
> --- a/src/mesa/drivers/dri/i965/brw_eu_validate.c
> +++ b/src/mesa/drivers/dri/i965/brw_eu_validate.c
> @@ -177,6 +177,7 @@ num_sources_from_inst(const struct gen_device_info *devinfo,
>           return 0;
>        }
>     } else {
> +      assert(desc->nsrc < 4);
>        return desc->nsrc;
>     }
>  
> -- 
> 2.11.0.453.g787f75f05
> 


More information about the mesa-dev mailing list