[Mesa-dev] [PATCH 2/3] vc4: fix arm64 build with Neon

[Eric Anholt]

Emil Velikov <emil.l.velikov at gmail.com> writes:

> On 30 January 2017 at 22:54, Rob Herring <robh at kernel.org> wrote:
>> The addition of Neon assembly breaks on arm64 builds because the assembly
>> syntax is different. For now, restrict Neon to ARMv7 builds.
>>
>> Signed-off-by: Rob Herring <robh at kernel.org>
>> ---
>>  src/gallium/drivers/vc4/vc4_tiling.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/vc4/vc4_tiling.h b/src/gallium/drivers/vc4/vc4_tiling.h
>> index 218130b2007c..ba1ad6fb3f7d 100644
>> --- a/src/gallium/drivers/vc4/vc4_tiling.h
>> +++ b/src/gallium/drivers/vc4/vc4_tiling.h
>> @@ -87,7 +87,7 @@ void vc4_store_tiled_image(void *dst, uint32_t dst_stride,
>>   * should extend this to have some runtime detection of being built for ARMv6
>>   * on a Pi 2+.
>>   */
>> -#if defined(__ARM_ARCH) && __ARM_ARCH >= 7
>> +#if defined(__ARM_ARCH) && __ARM_ARCH == 7
>>  #define NEON_SUFFIX(x) x ## _neon
>>  #else
>>  #define NEON_SUFFIX(x) x ## _base
> Things seem quite inconsistent in the area. Not sure if they are
> left-overs from dev stage or I'm missing something subtle.

This is left over from me landing the branch before writing the runtime
CPU detection that we need, as noted in the comment.

> Thanks
> Emil
> P.S. Did you have some ideas to have separate winsys (similar to
> virgl) - one for HW and another for SIM ?
> Is there any progress in the area ?

I took a serious look at it, but it appeared to be less capable than
what I have (it does sim under a swrast driver, rather than attaching to
GEM and appearing like a full HW driver that you could use for, say,
Xorg's backend).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170201/9668e5b1/attachment.sig>