[Mesa-dev] [PATCH] android: fix droid_create_image_from_prime_fd_yuv for YV12

[Tomasz Figa]

Hi Tapani,

On Thu, Feb 2, 2017 at 9:27 PM, Tapani Pälli <tapani.palli at intel.com> wrote:
> Earlier changes introduced is_ycrcb flag which checks the component
> order of u and v components. Condition for setting the flag was
> incorrect, with ycrcb we are supposed to have cr before cb.
>
> This patch (together with a fix in our gralloc) fixes corrupted
> rendering from 'test-opengl-gl2_yuvtex' native test and corrupted
> gallery thumbnail in application switcher on Android-IA.
>
> Fixes: 51727b1cf57e8c4630767eb9ead207b102ffa489
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>  src/egl/drivers/dri2/platform_android.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/egl/drivers/dri2/platform_android.c b/src/egl/drivers/dri2/platform_android.c
> index 36bd119..511b696 100644
> --- a/src/egl/drivers/dri2/platform_android.c
> +++ b/src/egl/drivers/dri2/platform_android.c
> @@ -629,7 +629,7 @@ droid_create_image_from_prime_fd_yuv(_EGLDisplay *disp, _EGLContext *ctx,
>      * so they can be interpreted as offsets. */
>     offsets[0] = (size_t)ycbcr.y;
>     /* We assume here that all the planes are located in one DMA-buf. */
> -   is_ycrcb = (size_t)ycbcr.cb < (size_t)ycbcr.cr;
> +   is_ycrcb = (size_t)ycbcr.cr < (size_t)ycbcr.cb;

Good catch. I must have done something really embarrassing while
testing the patch in question (or some last minute fixup...).

Reviewed-by: Tomasz Figa <tfiga at chromium.org>

Best regards,
Tomasz