[Mesa-dev] [PATCH 2/5] intel/isl: Add a supports_ccs_d helper

[Chad Versace]

On Thu 02 Feb 2017, Jason Ekstrand wrote:
> On Thu, Feb 2, 2017 at 10:13 AM, Chad Versace <chadversary at chromium.org>
> wrote:
> 
> > On Thu 02 Feb 2017, Anuj Phogat wrote:
> > > On Thu, Feb 2, 2017 at 9:03 AM, Jason Ekstrand <jason at jlekstrand.net>
> > wrote:
> > > > On Wed, Feb 1, 2017 at 4:07 PM, Anuj Phogat <anuj.phogat at gmail.com>
> > wrote:
> > > >>
> > > >> On Wed, Feb 1, 2017 at 2:40 PM, Jason Ekstrand <jason at jlekstrand.net>
> > > >> wrote:
> >
> > > >> > +/**
> > > >> > + * Returns true if the given format can support single-sample fast
> > > >> > clears.
> > > >> > + */
> > > >> > +bool
> > > >> > +isl_format_supports_ccs_d(const struct gen_device_info *devinfo,
> > > >> > +                          enum isl_format format)
> > > >> > +{
> > > >> > +   if (!isl_format_supports_rendering(devinfo, format))
> > > >> > +      return false;
> > > >> > +
> > > >> Add a check for non-MSRT?
> >
> > I think it should check or assert the gen version, at least. CCS_D first
> > appears in gen7. See intel_tiling_supports_non_msrt_mcs().
> >
> 
> agreed.  I'll add that.

Then
Reviewed-by: Chad Versace <chadversary at chromium.org>