[Mesa-dev] [PATCH 1/2] configure: libdrm is a single package, no split different versions

[Emil Velikov]

On 3 February 2017 at 01:41, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Wed, Feb 1, 2017 at 9:36 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 2 February 2017 at 02:33, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>> The intent of the libdrm_driver version limits has always been to not
>>> burden the "other" drivers with updating their libdrm unless really
>>> necessary. Unfortunately the configure script erroneously only checked
>>> the driver-specific bit and not the generic bit of libdrm as well. Fix
>>> this.
>>>
>> Haven't checked this explicitly, but I'm leaning that at least one
>> piece is broken.
>> If you are to change this, you must ensure that things build with the
>> numbers provided.
>
> I'm still not 100% sure what you're referring to. On the off chance
> that this change breaks some legitimate situation, we can revert it,
> or fix it up for the situation in question. Note that definition of
> "legitimate" isn't always going to be "it used to work" - sometimes
> things work but aren't worth supporting. (And sometimes they are.)
> Given Chad and Dave's reviews, and I believe some on-irc support for
> this approach, I'm going ahead and pushing this.
>
Above all: thank you Ilia and Dave for keeping up with our chat the other day.

This in combination combined with Dave's patch, would make 2/2 correct
- the order [things got in] is a bit iffy, but meh.

The change of approach here will break [although not so often] the
build for less commonly used/developed drivers.
Namely: as new libdrm API/ABI is used in the core/common parts, the
LIBDRM_REQUIRED bump will fall through the cracks.

Either way, let's cross that bridge if/when that happens.

Ilia, please add a comment above the LIBDRM_.*REQUIRED=2... lines
which describes things up a bit. I'm thinking of the following, but
I'd imagine you can improve on it:.

LIBDRM_REQUIRED is the libdrm version required by common/shared code.
LIBDRM_$HW_REQUIRED indicate is the required libdrm + libdrm_$hw used
for the specific $HW driver(s).

With some/any inline comment the patch is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks
Emil