[Mesa-dev] [RFC PATCH 1/1] st/dri: add a new driconf option override_glsl_version for ARK games

[Samuel Pitoiset]

On 02/03/2017 06:29 PM, Ilia Mirkin wrote:
> On Fri, Feb 3, 2017 at 12:23 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> This is similar to the MESA_GLSL_VERSION_OVERRIDE envvar (mainly
>> for developers). But this one has the advantage to be configured
>> for specific apps which require a context with an explicit version.
>>
>> For example, when an app requires a 3.2 core context, RadeonSI
>> will return a 4.5 context but this might fail (eg. ARK games).
>>
>> No need to add both "ARK: Survival Evolved" and "ARK: Survival
>> Of The Fittest" because the executable name is the same.
>>
>
> You're talking about these things in a manner that confuses me. You
> talk about GLSL version overrides, and that's what your patch does.
> However what you're really trying to do is limit the GL version of the
> resulting context. My guess specifically is that you want to turn off
> the context version upgrade logic. Either limit ctx->Version or try to
> adjust that logic.

That seems better. But it was easier to re-use the same logic as 
MESA_GLSL_VERSION_OVERRIDE.

>
> I don't see what this has to do with GLSL versions.
>
> Side-note - there's no GLSL version 320. Perhaps you meant 150 (the
> GLSL version associated with GL 3.2).

My mistake. It will fallback to GL 3.2 anyway but that's wrong.

>
>   -ilia
>