[Mesa-dev] [PATCH 1/3] ilo: EOL unplumb unmaintained gallium drv from winsys

[Emil Velikov]

Hi Edward,

On 2 February 2017 at 08:15, Edward O'Callaghan
<funfunctor at folklore1984.net> wrote:
> This is no longer actively maintained and is just
> accumulating bitrot.
>
> Signed-off-by: Edward O'Callaghan <funfunctor at folklore1984.net>
> ---
>  .../auxiliary/pipe-loader/pipe_loader_drm.c        |  5 ---
>  src/gallium/auxiliary/target-helpers/drm_helper.h  | 29 -------------
>  src/gallium/targets/dri/target.c                   |  3 --
>  src/gallium/targets/pipe-loader/pipe_i965.c        | 47 ----------------------
>  src/gallium/winsys/intel/drm/intel_drm_winsys.c    |  1 -
>  5 files changed, 85 deletions(-)
>  delete mode 100644 src/gallium/targets/pipe-loader/pipe_i965.c
>
Was there any problems with keeping this patch as 2/3 ? As-is this
causes interment 'breakage', since as we enable ilo one won't be able
to use it.
Not a huge deal, but still.

> --- a/src/gallium/winsys/intel/drm/intel_drm_winsys.c
> +++ b/src/gallium/winsys/intel/drm/intel_drm_winsys.c
> @@ -41,7 +41,6 @@
>  #include "util/u_inlines.h"
>  #include "util/u_memory.h"
>  #include "util/u_debug.h"
> -#include "ilo/core/intel_winsys.h"
>  #include "intel_drm_public.h"
>
Completely forgot that we can/should nuke the winsys as well. Can you
send a final patch 4/3 that does so ?

Thanks
Emil