[Mesa-dev] [PATCH 2/2] radv: Enable fast clears by default.

[Dave Airlie]

On 7 February 2017 at 09:53, Andres Rodriguez <andresx7 at gmail.com> wrote:
> For the series:
>
> Reviewed-by: Andres Rodriguez <andresx7 at gmail.com>
>
>
>
> On 2017-02-06 06:47 PM, Bas Nieuwenhuizen wrote:
>>
>> Works for me on dota2 and talos now.
>>
>> Signed-off-by: Bas Nieuwenhuizen <basni at google.com>

For all 3, happy dance and

Reviewed-by: Dave Airlie <airlied at redhat.com>

>> ---
>>   src/amd/vulkan/radv_device.c     | 4 ++--
>>   src/amd/vulkan/radv_meta_clear.c | 2 +-
>>   src/amd/vulkan/radv_private.h    | 2 +-
>>   3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
>> index 16c9c0ed684..98d4b91ac40 100644
>> --- a/src/amd/vulkan/radv_device.c
>> +++ b/src/amd/vulkan/radv_device.c
>> @@ -294,7 +294,7 @@ static const VkAllocationCallbacks default_alloc = {
>>   };
>>     static const struct debug_control radv_debug_options[] = {
>> -       {"fastclears", RADV_DEBUG_FAST_CLEARS},
>> +       {"nofastclears", RADV_DEBUG_NO_FAST_CLEARS},
>>         {"nodcc", RADV_DEBUG_NO_DCC},
>>         {"shaders", RADV_DEBUG_DUMP_SHADERS},
>>         {"nocache", RADV_DEBUG_NO_CACHE},
>> @@ -2157,7 +2157,7 @@ radv_initialise_color_surface(struct radv_device
>> *device,
>>                         cb->cb_color_info |= S_028C70_COMPRESSION(1);
>>         if (iview->image->cmask.size &&
>> -           (device->debug_flags & RADV_DEBUG_FAST_CLEARS))
>> +           !(device->debug_flags & RADV_DEBUG_NO_FAST_CLEARS))
>>                 cb->cb_color_info |= S_028C70_FAST_CLEAR(1);
>>         if (iview->image->surface.dcc_size && level_info->dcc_enabled)
>> diff --git a/src/amd/vulkan/radv_meta_clear.c
>> b/src/amd/vulkan/radv_meta_clear.c
>> index a42e8345716..6d02acc2dd1 100644
>> --- a/src/amd/vulkan/radv_meta_clear.c
>> +++ b/src/amd/vulkan/radv_meta_clear.c
>> @@ -841,7 +841,7 @@ emit_fast_color_clear(struct radv_cmd_buffer
>> *cmd_buffer,
>>         if (!iview->image->cmask.size && !iview->image->surface.dcc_size)
>>                 return false;
>>   -     if (!(cmd_buffer->device->debug_flags & RADV_DEBUG_FAST_CLEARS))
>> +       if (cmd_buffer->device->debug_flags & RADV_DEBUG_NO_FAST_CLEARS)
>>                 return false;
>>         if (!radv_layout_can_fast_clear(iview->image, image_layout,
>> radv_image_queue_family_mask(iview->image, cmd_buffer->queue_family_index,
>> cmd_buffer->queue_family_index)))
>> diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h
>> index 69ff3578e34..25ed5dec7cf 100644
>> --- a/src/amd/vulkan/radv_private.h
>> +++ b/src/amd/vulkan/radv_private.h
>> @@ -102,7 +102,7 @@ enum radv_mem_type {
>>       enum {
>> -       RADV_DEBUG_FAST_CLEARS       =   0x1,
>> +       RADV_DEBUG_NO_FAST_CLEARS    =   0x1,
>>         RADV_DEBUG_NO_DCC            =   0x2,
>>         RADV_DEBUG_DUMP_SHADERS      =   0x4,
>>         RADV_DEBUG_NO_CACHE          =   0x8,
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev