[Mesa-dev] [PATCH 06/17] configure.ac: Remove artificial --enable-gallium-llvm dependency

[Tobias Droste]

Does this cause problems if someone builds just intel classic drivers without 
LLVM installed?

I think without --disable-llvm you would get an error that LLVM is required 
for gallium even though nothing actually requires it in that configuration.

Or am I missing something?

I think you have to change:

if test "x$enable_gallium_llvm" == "xyes"; then
    llvm_check_version_for $LLVM_REQUIRED_GALLIUM "gallium"
    llvm_add_default_components "gallium"
fi

to

if test "x$enable_gallium_llvm" = "xyes" -a -n "$with_gallium_drivers"; then
    llvm_check_version_for $LLVM_REQUIRED_GALLIUM "gallium"
    llvm_add_default_components "gallium"
fi

Am Dienstag, 7. Februar 2017, 22:44:48 CET schrieb Emil Velikov:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> ... of non-empty --with-gallium-drivers.
> 
> Since we effectively made --enable-gallium-llvm mean --enable-llvm with
> earlier commits, we need to remove the, now artificial, requirement.
> 
> Otherwise we'll error (as below) when building RADV.
> 
> configure: error: --enable-gallium-llvm is required when building radv
> 
> Cc: Dave Airlie <airlied at redhat.com>
> CC: Tobias Droste <tdroste at gmx.de>
> Cc: "17.0" <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  configure.ac | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 4098da7666..88abc716c1 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1734,9 +1734,6 @@ AC_ARG_ENABLE([gallium-llvm],
>      [enable_gallium_llvm="$enableval"],
>      [enable_gallium_llvm=auto])
> 
> -if test -z "$with_gallium_drivers"; then
> -    enable_gallium_llvm=no
> -fi
>  if test "x$enable_gallium_llvm" = xauto; then
>      case "$host_cpu" in
>      i*86|x86_64|amd64) enable_gallium_llvm=yes;;