[Mesa-dev] [PATCH 06/17] configure.ac: Remove artificial --enable-gallium-llvm dependency

[Tobias Droste]

Am Mittwoch, 8. Februar 2017, 10:49:47 CET schrieb Emil Velikov:
> On 8 February 2017 at 01:08, Tobias Droste <tdroste at gmx.de> wrote:
> > Does this cause problems if someone builds just intel classic drivers
> > without LLVM installed?
> 
> The classic (with_dri_drivers) drivers are completely unrelated to
> anything LLVM. So no, it should not cause any issues.
> 
> > I think without --disable-llvm you would get an error that LLVM is
> > required
> > for gallium even though nothing actually requires it in that
> > configuration.
> 
> Is that --enable-gallium-llvm --without-gallium-drivers ?

Yes.

> 
> > Or am I missing something?
> > 
> > I think you have to change:
> > 
> > if test "x$enable_gallium_llvm" == "xyes"; then
> > 
> >     llvm_check_version_for $LLVM_REQUIRED_GALLIUM "gallium"
> >     llvm_add_default_components "gallium"
> > 
> > fi
> > 
> > to
> > 
> > if test "x$enable_gallium_llvm" = "xyes" -a -n "$with_gallium_drivers";
> > then> 
> >     llvm_check_version_for $LLVM_REQUIRED_GALLIUM "gallium"
> >     llvm_add_default_components "gallium"
> > 
> > fi
> 
> The only thing that I can think of is that with this patch we'll
> effectively check llvm version/components, even if we don't want to.
> That won't cause any issues afaict, although it is better to avoid.
> 
> I'll squash your fix.

It would cause problems if LLVM is not installed :-)

> 
> Thanks
> Emil