[Mesa-dev] [PATCH 3/3] etnaviv: remove number of pixel pipes validation

Christian Gmeiner christian.gmeiner at gmail.com
Thu Feb 9 07:19:40 UTC 2017


This validation was added before the etnaviv drm driver landed in
the linux kernel. Due some pre-merge API changes we had to fix-up
this value but with a mainline kernel this is not a problem anymore.

Lets remove that validation which also gets rid of problem caught
by Coverity, reported to me by imirkin.

Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
---
 src/gallium/drivers/etnaviv/etnaviv_screen.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c
index 8f2882f..c8d8d2f 100644
--- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
+++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c
@@ -578,16 +578,6 @@ etna_get_specs(struct etna_screen *screen)
       DBG("could not get ETNA_GPU_PIXEL_PIPES");
       goto fail;
    }
-   if (val < 1 && val > ETNA_MAX_PIXELPIPES) {
-      if (val == 0) {
-         fprintf(stderr, "Warning: zero pixel pipes (update kernel?)\n");
-         val = 1;
-      } else {
-         fprintf(stderr, "Error: bad pixel pipes value %u\n",
-                 (unsigned int)val);
-         goto fail;
-      }
-   }
    screen->specs.pixel_pipes = val;
 
    if (etna_gpu_get_param(screen->gpu, ETNA_GPU_NUM_CONSTANTS, &val)) {
-- 
2.7.4



More information about the mesa-dev mailing list