[Mesa-dev] [PATCH] util/disk_cache: error check asprintf()

Emil Velikov emil.l.velikov at gmail.com
Thu Feb 9 13:29:05 UTC 2017

On 9 February 2017 at 11:42, Timothy Arceri <tarceri at itsqueeze.com> wrote:

Fixes: f3d911463e8 "util/disk_cache: stop using ralloc_asprintf() unnecessarily"
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

>     _mesa_sha1_format(buf, key);
> -   asprintf(&filename, "%s/%c%c/%s", cache->path, buf[0], buf[1], buf + 2);
> +   if (asprintf(&filename, "%s/%c%c/%s", cache->path, buf[0],
We have three separate places that do %s/%c%c. Worth unifying - be
that a macro, static inline, other ?


More information about the mesa-dev mailing list