[Mesa-dev] [Mesa-stable] [PATCH 2/3] gallivm: Override getHostCPUName() "generic" w/ "pwr8" (v3)

[Emil Velikov]

Hi Ben,

On 19 January 2017 at 01:43, Ben Crocker <bcrocker at redhat.com> wrote:
> If llvm::sys::getHostCPUName() returns "generic", override
> it with "pwr8" (on PPC64LE).
>
> This is a work-around for a bug in LLVM: a table entry for "POWER8NVL"
> is missing, resulting in (big-endian) "generic" being returned on
> little-endian Power8NVL systems.  The result is that code that
> attempts to load the least significant 32 bits of a 64-bit quantity in
> memory loads the wrong half.
>
> This omission should be fixed in the next version of LLVM (4.0),
> but this work-around should be left in place in case some
> future version of POWER<n> also ends up unrepresented in LLVM's table.
>
Not sure how others feel, but imho you really want to have
this/similar comment in the code.

-Emil