[Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

[Christian Gmeiner]

Hi all

2017-02-09 13:50 GMT+01:00 Wladimir J. van der Laan <laanwj at gmail.com>:
>> > >>  /* shader object, for linking */
>> > >>  struct etna_shader {
>> > >> +   uint32_t id; /* for debug */
>> > >
>> > > Do you need this? It can certainly be removed from this patch, but I
>> > > don't know if you have other stuff building on top of this.
>> > >
>> >
>> > It gets used in dump_shader_info(..) which was added with this patch.
>>
>> My argument was that you could pass that value as an argument to
>> dump_shader_info(). I don't see why it needs to be stored inside the
>> etna_shader object.
>
> One advantage of storing it is that debug logging that refers to the shader
> can use the same number and it can be correlated with the info dumped earlier.
>
> Not that that is part of this patch, but that seems to be the goal.
>

Yeah.. thats the final goal.

> If not for that there's no real use for a counter anyway: just have whatever
> parses the output do the counting based on what is printed first.
>

For the moment I will pass the id as argument so everybody is happy and I can
push that change.

> But I think it's fine as it is.
>

greets
--
Christian Gmeiner, MSc

https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner