[Mesa-dev] [PATCH 05/26] glx: Implement __DRI_BACKGROUND_CALLABLE (v2)

[Emil Velikov]

On 8 February 2017 at 18:03, Marek Olšák <maraeo at gmail.com> wrote:
> From: Paul Berry <stereotype441 at gmail.com>
>
> v2: Marek: Add DRI3 support.
> ---
>  src/glx/dri2_glx.c | 16 +++++++++++++++-
>  src/glx/dri3_glx.c | 13 +++++++++++++
>  2 files changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
> index d6eb281..8dabcb3 100644
> --- a/src/glx/dri2_glx.c
> +++ b/src/glx/dri2_glx.c
> @@ -67,21 +67,21 @@ struct dri2_display
>      ** XFree86-DRI version information
>      */
>     int driMajor;
>     int driMinor;
>     int driPatch;
>     int swapAvailable;
>     int invalidateAvailable;
>
>     __glxHashTable *dri2Hash;
>
> -   const __DRIextension *loader_extensions[4];
> +   const __DRIextension *loader_extensions[5];
We might want to make this const __DRIextension ** and move the code
below to static const tables.
It's _not_ a blocker nor a requirement for the series.


>  static const __DRIuseInvalidateExtension dri2UseInvalidate = {
>     .base = { __DRI_USE_INVALIDATE, 1 }
>  };
>
> +static const __DRIbackgroundCallableExtension driBackgroundCallable = {
> +   { __DRI_BACKGROUND_CALLABLE, __DRI_BACKGROUND_CALLABLE_VERSION },
s/__DRI_BACKGROUND_CALLABLE_VERSION/1/

> +   driSetBackgroundContext,
Please use designated initialisers like the surrounding code.

Both here and for dri3.

Thanks
Emil