[Mesa-dev] [PATCH] tgsi: remove ureg_label_insn

Roland Scheidegger sroland at vmware.com
Fri Feb 10 22:20:50 UTC 2017


Am 10.02.2017 um 20:23 schrieb Emil Velikov:
> On 10 February 2017 at 19:03, Roland Scheidegger <sroland at vmware.com> wrote:
>> Sorry that I didn't catch that earlier, but I'll have to revert this.
>> This is required when dealing with the TGSI_OPCODE_CAL (and
>> TGSI_OPCODE_CALLNZ, albeit we don't actually need the latter and I don't
>> think anyone implements that, since we just emit a uif/cal/endif instead).
>> This corresponds to the d3d shader model 4 (and older actually) call
>> instruction:
>> But yes, TGSI_OPCODE_CAL isn't used by st/mesa.
>>
> Do add a note (used by XXX) to deter people from nuking it ;-)

Actually on closer look it seems it's not really needed. Since we only
used it for TGSI_OPCODE_CAL we can just use ureg_CAL instead which will
do exactly the same thing (this is also what nine does).
So, I'm not reverting it after all.

Roland



More information about the mesa-dev mailing list