[Mesa-dev] [PATCH 1/2] glsl: Handle packed_type == ivec4[] in lower_packed_varyings().

Iago Toral itoral at igalia.com
Mon Feb 13 09:34:19 UTC 2017


This patch is:

Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

On Sat, 2017-02-11 at 02:36 -0800, Kenneth Graunke wrote:
> For GS input arrays, we may turn a packed_type of ivec4 into an
> array of ivec4s.  We still want flat qualification.
> 
> Found by inspection.  Not known to help anything.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/compiler/glsl/lower_packed_varyings.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/compiler/glsl/lower_packed_varyings.cpp
> b/src/compiler/glsl/lower_packed_varyings.cpp
> index 1e9bdda12b1..13f7e5b52da 100644
> --- a/src/compiler/glsl/lower_packed_varyings.cpp
> +++ b/src/compiler/glsl/lower_packed_varyings.cpp
> @@ -704,7 +704,8 @@
> lower_packed_varyings_visitor::get_packed_varying_deref(
>        packed_var->data.centroid = unpacked_var->data.centroid;
>        packed_var->data.sample = unpacked_var->data.sample;
>        packed_var->data.patch = unpacked_var->data.patch;
> -      packed_var->data.interpolation = packed_type ==
> glsl_type::ivec4_type
> +      packed_var->data.interpolation =
> +         packed_type->without_array() == glsl_type::ivec4_type
>           ? unsigned(INTERP_MODE_FLAT) : unpacked_var-
> >data.interpolation;
>        packed_var->data.location = location;
>        packed_var->data.precision = unpacked_var->data.precision;


More information about the mesa-dev mailing list