[Mesa-dev] [Mesa-stable] [PATCH 2/2] i965/fs: emit MOV_INDIRECT with the source with the right register type

[Francisco Jerez]

Samuel Iglesias Gonsálvez <siglesias at igalia.com> writes:

> This was hiding bugs as it retyped the source to destination's type.
>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> Cc: "17.0" <mesa-stable at lists.freedesktop.org>

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>  src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> index 26ffbb169d2..65c75e63d27 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> @@ -428,7 +428,7 @@ fs_generator::generate_mov_indirect(fs_inst *inst,
>        brw_ADD(p, addr, indirect_byte_offset, brw_imm_uw(imm_byte_offset));
>        struct brw_reg ind_src = brw_VxH_indirect(0, 0);
>  
> -      brw_inst *mov = brw_MOV(p, dst, retype(ind_src, dst.type));
> +      brw_inst *mov = brw_MOV(p, dst, retype(ind_src, reg.type));
>  
>        if (devinfo->gen == 6 && dst.file == BRW_MESSAGE_REGISTER_FILE &&
>            !inst->get_next()->is_tail_sentinel() &&
> -- 
> 2.11.0
>
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170214/f7fdd997/attachment.sig>