[Mesa-dev] [PATCH 1/2] util: Add utility build-id code.

[Chad Versace]

On Tue 14 Feb 2017, Matt Turner wrote:
> On Tue, Feb 14, 2017 at 11:21 AM, Matt Turner <mattst88 at gmail.com> wrote:
> > On Tue, Feb 14, 2017 at 11:18 AM, Matt Turner <mattst88 at gmail.com> wrote:
> >> On Tue, Feb 14, 2017 at 10:59 AM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> >>> I'm not sure how I feel about the silent fall-backs.  At least in the Vulkan
> >>> driver, we should fail to compile if we can't get build-id.  Otherwise,
> >>> you'll end up compiling a driver that will always fail device creation.
> >>
> >> That was really an attempt to preempt questions about Windows.
> >>
> >> I am happy to drop it.
> >
> > Think-o. No, it's necessary for systems that don't have
> > dl_iterate_phdr (Windows, AFAIK).
> 
> I promise I'll stop replying to myself after this...
> 
> I guess dropping the fallback and simply wrapping build_id.c in
> HAVE_DL_ITERATE_PHDR is sufficient? Windows will build an empty source
> file, which is fine because no code should ever attempt to use it on
> Windows; and there would be no chance of the Vulkan driver calling
> (non-existent) fallback code.

I'm in favor of dropping the fallback stubs.