[Mesa-dev] [PATCH 5/6] docs/submittingpatches: assorted grammar fixes

Ben Crocker bcrocker at redhat.com
Tue Feb 14 22:34:47 UTC 2017



----- Original Message -----
> From: "Emil Velikov" <emil.l.velikov at gmail.com>
> To: mesa-dev at lists.freedesktop.org
> Cc: "emil l velikov" <emil.l.velikov at gmail.com>, "Ben Crocker" <bcrocker at redhat.com>
> Sent: Monday, February 13, 2017 8:42:22 AM
> Subject: [PATCH 5/6] docs/submittingpatches: assorted grammar fixes
> 
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Cc: Ben Crocker <bcrocker at redhat.com>
> Suggested-by: Ben Crocker <bcrocker at redhat.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Thanks for the suggestions Ben. Feel free to let us know/send patches if
> you spot anything else that looks odd.
> ---

You're welcome!
These changes look good to me.

-- Ben

>  docs/submittingpatches.html | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
> index d38ccad872..f8380b0a54 100644
> --- a/docs/submittingpatches.html
> +++ b/docs/submittingpatches.html
> @@ -72,7 +72,7 @@ if needed.  For example:
>      platform.
>  </pre>
>  <li>A "Signed-off-by:" line is not required, but not discouraged either.
> -<li>If a patch address a bugzilla issue, that should be noted in the
> +<li>If a patch addresses a bugzilla issue, that should be noted in the
>  patch comment.  For example:
>  <pre>
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
> @@ -205,7 +205,7 @@ as the issues are resolved first.
>  <h2 id="nominations">Nominating a commit for a stable branch</h2>
>  
>  <p>
> -There are three ways to nominate patch for inclusion of the stable branch
> and
> +There are three ways to nominate a patch for inclusion in the stable branch
> and
>  release.
>  </p>
>  <ul>
> @@ -247,7 +247,7 @@ exclusively for the older branch.
>  This "CC" syntax for patch nomination will cause patches to automatically be
>  copied to the mesa-stable@ mailing list when you use "git send-email" to
>  send
>  patches to the mesa-dev@ mailing list. If you prefer using --suppress-cc
>  that
> -won't have any effect negative effect on the patch nomination.
> +won't have any negative effect on the patch nomination.
>  
>  <p>
>  Note: by removing the tag [as the commit is pushed] the patch is
> @@ -283,7 +283,7 @@ be rejected:
>  
>  <ul>
>    <li>Patch introduces a regression. Any reported build breakage or other
> -  regression caused by a particular patch, (game no longer work, piglit test
> +  regression caused by a particular patch, (game no longer works, piglit
> test
>    changes from PASS to FAIL), is justification for rejecting a patch.</li>
>  
>    <li>Patch is too large, (say, larger than 100 lines)</li>
> @@ -322,7 +322,7 @@ be rejected:
>    Note: As an exception to this rule, the stable-release manager may accept
>    hardware-enabling "features". For example, backports of new code to
>    support
>    a newly-developed hardware product can be accepted if they can be
>    reasonably
> -  determined to not have effects on other hardware.</li>
> +  determined not to have effects on other hardware.</li>
>  
>    <li>Patch is a performance optimization. As a rule, performance patches
>    are
>    not candidates for the stable branch. The only exception might be a case
> --
> 2.11.0
> 
> 


More information about the mesa-dev mailing list