[Mesa-dev] [PATCH] anv: Rework the pipeline cache UUID

Jason Ekstrand jason at jlekstrand.net
Wed Feb 15 06:47:42 UTC 2017

On Tue, Feb 14, 2017 at 10:13 PM, Matt Turner <mattst88 at gmail.com> wrote:

> On Tue, Feb 14, 2017 at 3:52 PM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > The new version does a SHA1 sum of the timestamp together with the
> > device PCI ID.  This fixes a theoretical bug where, if you moved a drive
> > between machines, you could end up trying to use a pipeline cache from
> > one platform with a different platform.  Now we'll reject any cache that
> > is targeted at different hardware.
> I suspect that my patches from this morning brought this to the front
> of your mind. I would really rather you just make such a suggestion to
> me as a review comment than sending a conflicting patch before I have
> time to send v2.

Actually, they were completely coincidental.  What brought this to mind was
some work that I'm doing on a future feature that requires a bit more
UUIDing of things.  I realized there was a conflict but I figured that
switching from mtime to build-id and factoring in PCI ID were orthogonal
things.  I knew when I sent the patch that I would have to rebase it.  I'm
sorry if it came off as passive-aggressive or something.

In case I haven't said so, your figuring out the build-id stuff is very
much appreciated!  It's way better than mtime!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170214/3c12e75b/attachment.html>

More information about the mesa-dev mailing list