[Mesa-dev] [PATCH 1/5] i965/fs: Fix the inline nir_op_pack_double optimization

Kenneth Graunke kenneth at whitecape.org
Wed Feb 15 09:39:56 UTC 2017


On Tuesday, February 14, 2017 11:29:47 PM PST Jason Ekstrand wrote:
> We can only do the optimization if the source *is* SSA.
> 
> Cc: "13.0 17.0" <mesa-stable at lists.freedesktop.org>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> index 991c20f..94f2751 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
> @@ -1219,7 +1219,7 @@ fs_visitor::nir_emit_alu(const fs_builder &bld, nir_alu_instr *instr)
>         * the unpack operation.
>         */
>        for (int i = 0; i < 2; i++) {
> -         if (instr->src[i].src.is_ssa)
> +         if (!instr->src[i].src.is_ssa)
>              continue;
>  
>           const nir_instr *parent_instr = instr->src[i].src.ssa->parent_instr;
> 

Series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170215/14b34cbf/attachment.sig>


More information about the mesa-dev mailing list