[Mesa-dev] [PATCH 4/4] docs/submittingpatches.html: document the Fixes tag

Nicolai Hähnle nhaehnle at gmail.com
Wed Feb 15 12:34:40 UTC 2017


Good changes, I think. Except for a comment on patch #3, the series is

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

On 13.02.2017 20:23, Emil Velikov wrote:
> From: Emil Velikov <emil.veliko at collabora.com>
>
> Provide information and an example.
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  docs/submittingpatches.html | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html
> index 564ad731b2..6ca39c4825 100644
> --- a/docs/submittingpatches.html
> +++ b/docs/submittingpatches.html
> @@ -78,6 +78,11 @@ patch comment.  For example:
>  <pre>
>     Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89689
>  </pre>
> +<li>If a patch addresses a issue introduced with earlier commit, that should be
> +noted in the patch comment.  For example:
> +<pre>
> +   Fixes: d7b3707c612 "util/disk_cache: use stat() to check if entry is a directory"
> +</pre>
>  <li>If there have been several revisions to a patch during the review
>  process, they should be noted such as in this example:
>  <pre>
>



More information about the mesa-dev mailing list