[Mesa-dev] [PATCH 2/2] anv: Use build-id for pipeline cache UUID.

Emil Velikov emil.l.velikov at gmail.com
Wed Feb 15 20:59:20 UTC 2017


On 15 February 2017 at 19:00, Matt Turner <mattst88 at gmail.com> wrote:
> On Wed, Feb 15, 2017 at 6:05 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> Hi Matt,
>>
>> On 14 February 2017 at 23:58, Matt Turner <mattst88 at gmail.com> wrote:
>>> The --build-id=... ld flag has been present since binutils-2.18,
>>> released 28 Aug 2007.
>>> ---
>>>  src/intel/vulkan/Makefile.am  |  1 +
>>>  src/intel/vulkan/anv_device.c | 28 +++++++---------------------
>>>  2 files changed, 8 insertions(+), 21 deletions(-)
>>>
>>> diff --git a/src/intel/vulkan/Makefile.am b/src/intel/vulkan/Makefile.am
>>> index 95f276e..4197b0e 100644
>>> --- a/src/intel/vulkan/Makefile.am
>>> +++ b/src/intel/vulkan/Makefile.am
>>> @@ -165,6 +165,7 @@ libvulkan_intel_la_LDFLAGS = \
>>>         -module \
>>>         -no-undefined \
>>>         -avoid-version \
>>> +       -Wl,--build-id=sha1 \
>> Did you mean to have this as-is and update to $sha1 as a follow-up commit ?
>
> I'm not sure what you mean.
>
> I added -Wl,--build-id=sha1 in this patch, because it is at this point
> that we begin relying on having a .note.gnu.build-id section.

Scratch that, I should have read the build-id man page more carefully.

-Emil


More information about the mesa-dev mailing list