[Mesa-dev] [PATCH] [swr] fix windows build

Ilia Mirkin imirkin at alum.mit.edu
Wed Feb 15 22:25:04 UTC 2017


I'd rather see the remainder of the headers fixed to be includable
from C++ contexts. extern "C" { #include } is an anti-pattern...

  -ilia

On Wed, Feb 15, 2017 at 5:23 PM, George Kyriazis
<george.kyriazis at intel.com> wrote:
> move util/u_upload_mgr.h inside extern "C"
> ---
>  src/gallium/drivers/swr/swr_context.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/swr/swr_context.cpp b/src/gallium/drivers/swr/swr_context.cpp
> index 2e37bac..04ff146 100644
> --- a/src/gallium/drivers/swr/swr_context.cpp
> +++ b/src/gallium/drivers/swr/swr_context.cpp
> @@ -33,9 +33,9 @@
>  #include "util/u_inlines.h"
>  #include "util/u_format.h"
>  #include "util/u_atomic.h"
> -#include "util/u_upload_mgr.h"
>
>  extern "C" {
> +#include "util/u_upload_mgr.h"
>  #include "util/u_transfer.h"
>  #include "util/u_surface.h"
>  }
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list