[Mesa-dev] [PATCH] glx/glvnd: Fix GLXdispatchIndex sorting
emil.l.velikov at gmail.com
Thu Feb 16 15:38:28 UTC 2017
On 6 February 2017 at 13:09, Hans de Goede <hdegoede at redhat.com> wrote:
> Commit 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and indices")
> fixed the sorting of the array initializers in g_glxglvnddispatchfuncs.c
> because FindGLXFunction's binary search needs these to be sorted
> That commit also mostly fixed the sorting of the DI_foo defines in
> g_glxglvnddispatchindices.h, which is what actually matters as the
> arrays are initialized using "[DI_foo] = glXfoo," but a small error
> crept in which at least causes glXGetVisualFromFBConfigSGIX to not
> resolve, breaking games such as "The Binding of Isaac: Rebirth" and
> "Crypt of the NecroDancer" from Steam not working and possible causes
> other problems too.
> This commit fixes the last of the sorting errors, fixing these mentioned
> games not working.
> Fixes: 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and indices")
> Cc: "13.0" <mesa-stable at lists.freedesktop.org>
> Cc: "17.0" <mesa-stable at lists.freedesktop.org>
> Cc: Adam Jackson <ajax at redhat.com>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
A while back as Adam did a similar thing, it was suggested that we get
an actual test so that things don't break.
I was stupid^Wkind enough to opt for "we can have such patch as
follow-up", only that it never came.
As you can imagine not cool...
Can we have one now, please ?
More information about the mesa-dev