[Mesa-dev] [PATCH] mesa/formatquery: use consistent local function names

Alejandro Piñeiro apinheiro at igalia.com
Fri Feb 17 09:05:16 UTC 2017


Gentle ping for a really trivial patch.

On 11/02/17 17:21, Alejandro Piñeiro wrote:
> ---
>  src/mesa/main/formatquery.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c
> index 29df958..598d34d 100644
> --- a/src/mesa/main/formatquery.c
> +++ b/src/mesa/main/formatquery.c
> @@ -718,8 +718,8 @@ _mesa_query_internal_format_default(struct gl_context *ctx, GLenum target,
>   * arb_internalformat_query2 spec.
>   */
>  static GLenum
> -equivalentSizePname(GLenum target,
> -                    GLenum pname)
> +_equivalent_size_pname(GLenum target,
> +                       GLenum pname)
>  {
>     switch (target) {
>     case GL_TEXTURE_1D:
> @@ -763,7 +763,7 @@ equivalentSizePname(GLenum target,
>   * per-se, so we can't just call _mesa_get_texture_dimension directly.
>   */
>  static GLint
> -get_target_dimensions(GLenum target)
> +_get_target_dimensions(GLenum target)
>  {
>     switch(target) {
>     case GL_TEXTURE_BUFFER:
> @@ -788,7 +788,7 @@ get_target_dimensions(GLenum target)
>   *  <skip>."
>   */
>  static GLint
> -get_min_dimensions(GLenum pname)
> +_get_min_dimensions(GLenum pname)
>  {
>     switch(pname) {
>     case GL_MAX_WIDTH:
> @@ -807,7 +807,7 @@ get_min_dimensions(GLenum pname)
>   * dimensions.
>   */
>  static bool
> -is_multisample_target(GLenum target)
> +_is_multisample_target(GLenum target)
>  {
>     switch(target) {
>     case GL_TEXTURE_2D_MULTISAMPLE:
> @@ -1016,12 +1016,12 @@ _mesa_GetInternalformativ(GLenum target, GLenum internalformat, GLenum pname,
>         * "If the resource does not have at least two dimensions, or if the
>         * resource is unsupported, zero is returned."
>         */
> -      dimensions = get_target_dimensions(target);
> -      min_dimensions = get_min_dimensions(pname);
> +      dimensions = _get_target_dimensions(target);
> +      min_dimensions = _get_min_dimensions(pname);
>        if (dimensions < min_dimensions)
>           goto end;
>  
> -      get_pname = equivalentSizePname(target, pname);
> +      get_pname = _equivalent_size_pname(target, pname);
>        if (get_pname == 0)
>           goto end;
>  
> @@ -1055,7 +1055,7 @@ _mesa_GetInternalformativ(GLenum target, GLenum internalformat, GLenum pname,
>         * returned as MAX_HEIGHT or MAX_DEPTH */
>        for (i = 0; i < 4; i++) {
>           if (max_dimensions_pnames[i] == GL_SAMPLES &&
> -             !is_multisample_target(target))
> +             !_is_multisample_target(target))
>              continue;
>  
>           _mesa_GetInternalformativ(target, internalformat,



More information about the mesa-dev mailing list