[Mesa-dev] [PATCH 2/5] freedreno: add support for user index buffers

Marek Olšák maraeo at gmail.com
Fri Feb 17 13:53:16 UTC 2017

On Fri, Feb 17, 2017 at 2:14 PM, Rob Clark <robdclark at gmail.com> wrote:
> Haven't had a chance to try this yet, but looks reasonable.  But how
> common would it be that a single indexbuf gets re-used for multiple
> draws?  I wonder if it would be better to just do the upload in
> set_index_buffer() instead?

No, we need draw_info->count for the upload.

> Also, I might have missed some discussion (have been buried in kernel
> stuff lately so haven't been following mesa-dev so much), but what was
> the motivation to remove IB upload support from mesa/st?

My motivation was to reduce the amount of work done in st_draw_vbo.

> (Oh, and in patch 1/5, I guess you meant to split the u_helpers and
> etnaviv into two separate patches?  not sure if you accidentally
> squashed them together?)

That was on purpose.


More information about the mesa-dev mailing list