[Mesa-dev] [PATCH] radv: Invert ring SGPR check.

Edward O'Callaghan funfunctor at folklore1984.net
Sun Feb 19 04:25:45 UTC 2017


Acked-by: Edward O'Callaghan <funfunctor at folklore1984.net>

On 02/19/2017 01:39 PM, Bas Nieuwenhuizen wrote:
> I assume this wants to check if all pipelines use the same SGPR for
> the rings.
> 
> Signed-off-by: Bas Nieuwenhuizen <basni at google.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 75149c5ba1a..57d55b34e36 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -1900,7 +1900,7 @@ void radv_CmdBindPipeline(
>  			if (cmd_buffer->ring_offsets_idx == -1)
>  				cmd_buffer->ring_offsets_idx = loc->sgpr_idx;
>  			else if (loc->sgpr_idx != -1)
> -				assert(loc->sgpr_idx != cmd_buffer->ring_offsets_idx);
> +				assert(loc->sgpr_idx == cmd_buffer->ring_offsets_idx);
>  		}
>  		break;
>  	default:
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170219/5c46d708/attachment.sig>


More information about the mesa-dev mailing list