[Mesa-dev] [PATCH 5/5] gallium: remove PIPE_CAP_USER_INDEX_BUFFERS

Nicolai Hähnle nhaehnle at gmail.com
Sun Feb 19 09:13:33 UTC 2017


On 17.02.2017 11:27, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> all drivers support it

Patches 4 & 5:

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

1-3 look good to me as well, but I'd wait for feedback from the 
corresponding driver authors.

> ---
>  src/gallium/docs/source/screen.rst               | 4 ----
>  src/gallium/drivers/etnaviv/etnaviv_screen.c     | 1 -
>  src/gallium/drivers/freedreno/freedreno_screen.c | 1 -
>  src/gallium/drivers/i915/i915_screen.c           | 1 -
>  src/gallium/drivers/llvmpipe/lp_screen.c         | 1 -
>  src/gallium/drivers/nouveau/nv30/nv30_screen.c   | 1 -
>  src/gallium/drivers/nouveau/nv50/nv50_screen.c   | 1 -
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c   | 1 -
>  src/gallium/drivers/r300/r300_screen.c           | 1 -
>  src/gallium/drivers/r600/r600_pipe.c             | 1 -
>  src/gallium/drivers/radeonsi/si_pipe.c           | 1 -
>  src/gallium/drivers/softpipe/sp_screen.c         | 1 -
>  src/gallium/drivers/svga/svga_screen.c           | 1 -
>  src/gallium/drivers/swr/swr_screen.cpp           | 1 -
>  src/gallium/drivers/vc4/vc4_screen.c             | 1 -
>  src/gallium/drivers/virgl/virgl_screen.c         | 1 -
>  src/gallium/include/pipe/p_defines.h             | 1 -
>  17 files changed, 20 deletions(-)
>
> diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst
> index 74c8cec..b08c3ce 100644
> --- a/src/gallium/docs/source/screen.rst
> +++ b/src/gallium/docs/source/screen.rst
> @@ -108,24 +108,20 @@ The integer capabilities:
>    limitation.  If true, pipe_vertex_buffer::buffer_offset must always be aligned
>    to 4.  If false, there are no restrictions on the offset.
>  * ``PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY``: This CAP describes a hw
>    limitation.  If true, pipe_vertex_buffer::stride must always be aligned to 4.
>    If false, there are no restrictions on the stride.
>  * ``PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY``: This CAP describes
>    a hw limitation.  If true, pipe_vertex_element::src_offset must always be
>    aligned to 4.  If false, there are no restrictions on src_offset.
>  * ``PIPE_CAP_COMPUTE``: Whether the implementation supports the
>    compute entry points defined in pipe_context and pipe_screen.
> -* ``PIPE_CAP_USER_INDEX_BUFFERS``: Whether user index buffers are supported.
> -  If not, the state tracker must upload all indices which are not in hw
> -  resources.  If user-space buffers are supported, the driver must also still
> -  accept HW resource buffers.
>  * ``PIPE_CAP_USER_CONSTANT_BUFFERS``: Whether user-space constant buffers
>    are supported.  If not, the state tracker must put constants into HW
>    resources/buffers.  If user-space constant buffers are supported, the
>    driver must still accept HW constant buffers also.
>  * ``PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT``: Describes the required
>    alignment of pipe_constant_buffer::buffer_offset.
>  * ``PIPE_CAP_START_INSTANCE``: Whether the driver supports
>    pipe_draw_info::start_instance.
>  * ``PIPE_CAP_QUERY_TIMESTAMP``: Whether PIPE_QUERY_TIMESTAMP and
>    the pipe_screen::get_timestamp hook are implemented.
> diff --git a/src/gallium/drivers/etnaviv/etnaviv_screen.c b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> index 93eeb58..2d128b3 100644
> --- a/src/gallium/drivers/etnaviv/etnaviv_screen.c
> +++ b/src/gallium/drivers/etnaviv/etnaviv_screen.c
> @@ -129,21 +129,20 @@ etna_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER:
>     case PIPE_CAP_SM3:
>     case PIPE_CAP_TEXTURE_BARRIER:
>     case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>     case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_USER_CONSTANT_BUFFERS:
>     case PIPE_CAP_TGSI_TEXCOORD:
>     case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>        return 1;
>
>     /* Memory */
>     case PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT:
>        return 256;
>     case PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT:
>        return 4; /* XXX could easily be supported */
>     case PIPE_CAP_GLSL_FEATURE_LEVEL:
>        return 120;
>
> diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c b/src/gallium/drivers/freedreno/freedreno_screen.c
> index e1b95a6..e667187 100644
> --- a/src/gallium/drivers/freedreno/freedreno_screen.c
> +++ b/src/gallium/drivers/freedreno/freedreno_screen.c
> @@ -172,21 +172,20 @@ fd_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>  	case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER:
>  	case PIPE_CAP_SEAMLESS_CUBE_MAP:
>  	case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
>  	case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>  	case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>  	case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
>  	case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>  	case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>  	case PIPE_CAP_STRING_MARKER:
>  	case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
> -	case PIPE_CAP_USER_INDEX_BUFFERS:
>  		return 1;
>
>  	case PIPE_CAP_VERTEXID_NOBASE:
>  		return is_a3xx(screen) || is_a4xx(screen);
>
>  	case PIPE_CAP_USER_CONSTANT_BUFFERS:
>  		return is_a4xx(screen) ? 0 : 1;
>
>  	case PIPE_CAP_SHADER_STENCIL_EXPORT:
>  	case PIPE_CAP_TGSI_TEXCOORD:
> diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c
> index 038cca1..28703b8 100644
> --- a/src/gallium/drivers/i915/i915_screen.c
> +++ b/src/gallium/drivers/i915/i915_screen.c
> @@ -191,21 +191,20 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap)
>     case PIPE_CAP_MIXED_FRAMEBUFFER_SIZES:
>     case PIPE_CAP_POINT_SPRITE:
>     case PIPE_CAP_PRIMITIVE_RESTART: /* draw module */
>     case PIPE_CAP_TEXTURE_SHADOW_MAP:
>     case PIPE_CAP_TWO_SIDED_STENCIL:
>     case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR:
>     case PIPE_CAP_BLEND_EQUATION_SEPARATE:
>     case PIPE_CAP_TGSI_INSTANCEID:
>     case PIPE_CAP_VERTEX_COLOR_CLAMPED:
>     case PIPE_CAP_USER_VERTEX_BUFFERS:
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>     case PIPE_CAP_USER_CONSTANT_BUFFERS:
>     case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
>        return 1;
>
>     /* Unsupported features (boolean caps). */
>     case PIPE_CAP_MAX_TEXTURE_ARRAY_LAYERS:
>     case PIPE_CAP_DEPTH_CLIP_DISABLE:
>     case PIPE_CAP_INDEP_BLEND_ENABLE:
>     case PIPE_CAP_INDEP_BLEND_FUNC:
>     case PIPE_CAP_SHADER_STENCIL_EXPORT:
> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
> index 76a30a6..7858db9 100644
> --- a/src/gallium/drivers/llvmpipe/lp_screen.c
> +++ b/src/gallium/drivers/llvmpipe/lp_screen.c
> @@ -207,21 +207,20 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
>     case PIPE_CAP_VERTEX_COLOR_CLAMPED:
>        return 1;
>     case PIPE_CAP_GLSL_FEATURE_LEVEL:
>        return 330;
>     case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>        return 0;
>     case PIPE_CAP_COMPUTE:
>        return 0;
>     case PIPE_CAP_USER_VERTEX_BUFFERS:
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>        return 1;
>     case PIPE_CAP_USER_CONSTANT_BUFFERS:
>        return 0;
>     case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_TGSI_TEXCOORD:
>        return 0;
>     case PIPE_CAP_DRAW_INDIRECT:
>        return 1;
> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> index 6c58a0a..bc31810 100644
> --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> +++ b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> @@ -84,21 +84,20 @@ nv30_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_QUERY_TIMESTAMP:
>     case PIPE_CAP_TEXTURE_SHADOW_MAP:
>     case PIPE_CAP_TEXTURE_SWIZZLE:
>     case PIPE_CAP_DEPTH_CLIP_DISABLE:
>     case PIPE_CAP_TGSI_FS_COORD_ORIGIN_UPPER_LEFT:
>     case PIPE_CAP_TGSI_FS_COORD_ORIGIN_LOWER_LEFT:
>     case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER:
>     case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER:
>     case PIPE_CAP_TGSI_TEXCOORD:
>     case PIPE_CAP_USER_CONSTANT_BUFFERS:
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>     case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>     case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
>     case PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER:
>        return 1;
>     /* nv35 capabilities */
>     case PIPE_CAP_DEPTH_BOUNDS_TEST:
>        return eng3d->oclass == NV35_3D_CLASS || eng3d->oclass >= NV40_3D_CLASS;
>     /* nv4x capabilities */
> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> index aa756ed..83f67ca 100644
> --- a/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> +++ b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> @@ -168,21 +168,20 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER:
>     case PIPE_CAP_PRIMITIVE_RESTART:
>     case PIPE_CAP_TGSI_INSTANCEID:
>     case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR:
>     case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>     case PIPE_CAP_CONDITIONAL_RENDER:
>     case PIPE_CAP_TEXTURE_BARRIER:
>     case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>     case PIPE_CAP_START_INSTANCE:
>     case PIPE_CAP_USER_CONSTANT_BUFFERS:
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>     case PIPE_CAP_USER_VERTEX_BUFFERS:
>     case PIPE_CAP_TEXTURE_MULTISAMPLE:
>     case PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER:
>     case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>     case PIPE_CAP_SAMPLER_VIEW_TARGET:
>     case PIPE_CAP_CONDITIONAL_RENDER_INVERTED:
>     case PIPE_CAP_CLIP_HALFZ:
>     case PIPE_CAP_POLYGON_OFFSET_CLAMP:
>     case PIPE_CAP_QUERY_PIPELINE_STATISTICS:
>     case PIPE_CAP_TEXTURE_FLOAT_LINEAR:
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> index 30efac8..b07e54f 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> @@ -200,21 +200,20 @@ nvc0_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_TGSI_INSTANCEID:
>     case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR:
>     case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>     case PIPE_CAP_CONDITIONAL_RENDER:
>     case PIPE_CAP_TEXTURE_BARRIER:
>     case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>     case PIPE_CAP_START_INSTANCE:
>     case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>     case PIPE_CAP_DRAW_INDIRECT:
>     case PIPE_CAP_USER_CONSTANT_BUFFERS:
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>     case PIPE_CAP_USER_VERTEX_BUFFERS:
>     case PIPE_CAP_TEXTURE_QUERY_LOD:
>     case PIPE_CAP_SAMPLE_SHADING:
>     case PIPE_CAP_TEXTURE_GATHER_OFFSETS:
>     case PIPE_CAP_TEXTURE_GATHER_SM5:
>     case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>     case PIPE_CAP_CONDITIONAL_RENDER_INVERTED:
>     case PIPE_CAP_SAMPLER_VIEW_TARGET:
>     case PIPE_CAP_CLIP_HALFZ:
>     case PIPE_CAP_POLYGON_OFFSET_CLAMP:
> diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c
> index 7ea6a1c..903502d 100644
> --- a/src/gallium/drivers/r300/r300_screen.c
> +++ b/src/gallium/drivers/r300/r300_screen.c
> @@ -102,21 +102,20 @@ static int r300_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>          case PIPE_CAP_OCCLUSION_QUERY:
>          case PIPE_CAP_TEXTURE_SHADOW_MAP:
>          case PIPE_CAP_TEXTURE_MIRROR_CLAMP:
>          case PIPE_CAP_BLEND_EQUATION_SEPARATE:
>          case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR:
>          case PIPE_CAP_TGSI_FS_COORD_ORIGIN_UPPER_LEFT:
>          case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_HALF_INTEGER:
>          case PIPE_CAP_CONDITIONAL_RENDER:
>          case PIPE_CAP_TEXTURE_BARRIER:
>          case PIPE_CAP_TGSI_CAN_COMPACT_CONSTANTS:
> -        case PIPE_CAP_USER_INDEX_BUFFERS:
>          case PIPE_CAP_USER_CONSTANT_BUFFERS:
>          case PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER:
>          case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>          case PIPE_CAP_CLIP_HALFZ:
>              return 1;
>
>          case PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT:
>              return R300_BUFFER_ALIGNMENT;
>
>          case PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT:
> diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c
> index 1803c26..68c4ccc 100644
> --- a/src/gallium/drivers/r600/r600_pipe.c
> +++ b/src/gallium/drivers/r600/r600_pipe.c
> @@ -254,21 +254,20 @@ static int r600_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>  	case PIPE_CAP_SEAMLESS_CUBE_MAP:
>  	case PIPE_CAP_PRIMITIVE_RESTART:
>  	case PIPE_CAP_CONDITIONAL_RENDER:
>  	case PIPE_CAP_TEXTURE_BARRIER:
>  	case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
>  	case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>  	case PIPE_CAP_TGSI_INSTANCEID:
>  	case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
>  	case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
>  	case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY:
> -	case PIPE_CAP_USER_INDEX_BUFFERS:
>  	case PIPE_CAP_USER_CONSTANT_BUFFERS:
>  	case PIPE_CAP_START_INSTANCE:
>  	case PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS:
>  	case PIPE_CAP_TEXTURE_BUFFER_OBJECTS:
>  	case PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER:
>  	case PIPE_CAP_QUERY_PIPELINE_STATISTICS:
>  	case PIPE_CAP_TEXTURE_MULTISAMPLE:
>  	case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>  	case PIPE_CAP_TGSI_VS_WINDOW_SPACE_POSITION:
>  	case PIPE_CAP_TGSI_VS_LAYER_VIEWPORT:
> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
> index 843c6b3..a0e90a8 100644
> --- a/src/gallium/drivers/radeonsi/si_pipe.c
> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
> @@ -357,21 +357,20 @@ static int si_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>  	case PIPE_CAP_TGSI_FS_COORD_PIXEL_CENTER_INTEGER:
>  	case PIPE_CAP_SM3:
>  	case PIPE_CAP_SEAMLESS_CUBE_MAP:
>  	case PIPE_CAP_PRIMITIVE_RESTART:
>  	case PIPE_CAP_CONDITIONAL_RENDER:
>  	case PIPE_CAP_TEXTURE_BARRIER:
>  	case PIPE_CAP_INDEP_BLEND_ENABLE:
>  	case PIPE_CAP_INDEP_BLEND_FUNC:
>  	case PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE:
>  	case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
> -	case PIPE_CAP_USER_INDEX_BUFFERS:
>  	case PIPE_CAP_USER_CONSTANT_BUFFERS:
>  	case PIPE_CAP_START_INSTANCE:
>  	case PIPE_CAP_NPOT_TEXTURES:
>  	case PIPE_CAP_MIXED_FRAMEBUFFER_SIZES:
>  	case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
>  	case PIPE_CAP_VERTEX_COLOR_CLAMPED:
>  	case PIPE_CAP_FRAGMENT_COLOR_CLAMPED:
>          case PIPE_CAP_PREFER_BLIT_BASED_TEXTURE_TRANSFER:
>  	case PIPE_CAP_TGSI_INSTANCEID:
>  	case PIPE_CAP_COMPUTE:
> diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c
> index 02eff91..bdb106c 100644
> --- a/src/gallium/drivers/softpipe/sp_screen.c
> +++ b/src/gallium/drivers/softpipe/sp_screen.c
> @@ -153,21 +153,20 @@ softpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>        return 1;
>     case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>        return 0;
>     case PIPE_CAP_GLSL_FEATURE_LEVEL:
>        return 330;
>     case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>        return 0;
>     case PIPE_CAP_COMPUTE:
>        return 1;
>     case PIPE_CAP_USER_VERTEX_BUFFERS:
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>     case PIPE_CAP_USER_CONSTANT_BUFFERS:
>     case PIPE_CAP_STREAM_OUTPUT_PAUSE_RESUME:
>     case PIPE_CAP_STREAM_OUTPUT_INTERLEAVE_BUFFERS:
>     case PIPE_CAP_TGSI_VS_LAYER_VIEWPORT:
>     case PIPE_CAP_DOUBLES:
>     case PIPE_CAP_INT64:
>     case PIPE_CAP_INT64_DIVMOD:
>        return 1;
>     case PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT:
>        return 16;
> diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c
> index 8af66b7..90f8e2b 100644
> --- a/src/gallium/drivers/svga/svga_screen.c
> +++ b/src/gallium/drivers/svga/svga_screen.c
> @@ -175,21 +175,20 @@ static int
>  svga_get_param(struct pipe_screen *screen, enum pipe_cap param)
>  {
>     struct svga_screen *svgascreen = svga_screen(screen);
>     struct svga_winsys_screen *sws = svgascreen->sws;
>     SVGA3dDevCapResult result;
>
>     switch (param) {
>     case PIPE_CAP_NPOT_TEXTURES:
>     case PIPE_CAP_MIXED_FRAMEBUFFER_SIZES:
>     case PIPE_CAP_MIXED_COLOR_DEPTH_BITS:
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>        return 1;
>     case PIPE_CAP_TWO_SIDED_STENCIL:
>        return 1;
>     case PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS:
>        /*
>         * "In virtually every OpenGL implementation and hardware,
>         * GL_MAX_DUAL_SOURCE_DRAW_BUFFERS is 1"
>         * http://www.opengl.org/wiki/Blending
>         */
>        return sws->have_vgpu10 ? 1 : 0;
> diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp
> index f4fe1f3..f5e000c 100644
> --- a/src/gallium/drivers/swr/swr_screen.cpp
> +++ b/src/gallium/drivers/swr/swr_screen.cpp
> @@ -224,21 +224,20 @@ swr_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_TGSI_INSTANCEID:
>     case PIPE_CAP_VERTEX_ELEMENT_INSTANCE_DIVISOR:
>     case PIPE_CAP_START_INSTANCE:
>     case PIPE_CAP_SEAMLESS_CUBE_MAP:
>     case PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE:
>     case PIPE_CAP_CONDITIONAL_RENDER:
>     case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
>     case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>     case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>     case PIPE_CAP_USER_VERTEX_BUFFERS:
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>     case PIPE_CAP_USER_CONSTANT_BUFFERS:
>     case PIPE_CAP_STREAM_OUTPUT_INTERLEAVE_BUFFERS:
>     case PIPE_CAP_QUERY_TIMESTAMP:
>     case PIPE_CAP_TEXTURE_BUFFER_OBJECTS:
>     case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>     case PIPE_CAP_FAKE_SW_MSAA:
>     case PIPE_CAP_DRAW_INDIRECT:
>     case PIPE_CAP_UMA:
>     case PIPE_CAP_CONDITIONAL_RENDER_INVERTED:
>     case PIPE_CAP_CLIP_HALFZ:
> diff --git a/src/gallium/drivers/vc4/vc4_screen.c b/src/gallium/drivers/vc4/vc4_screen.c
> index 3b2c265..31ab0db 100644
> --- a/src/gallium/drivers/vc4/vc4_screen.c
> +++ b/src/gallium/drivers/vc4/vc4_screen.c
> @@ -116,21 +116,20 @@ vc4_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>          case PIPE_CAP_VERTEX_COLOR_CLAMPED:
>          case PIPE_CAP_VERTEX_COLOR_UNCLAMPED:
>          case PIPE_CAP_FRAGMENT_COLOR_CLAMPED:
>          case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>          case PIPE_CAP_NPOT_TEXTURES:
>          case PIPE_CAP_SHAREABLE_SHADERS:
>          case PIPE_CAP_USER_CONSTANT_BUFFERS:
>          case PIPE_CAP_TEXTURE_SHADOW_MAP:
>          case PIPE_CAP_BLEND_EQUATION_SEPARATE:
>          case PIPE_CAP_TWO_SIDED_STENCIL:
> -        case PIPE_CAP_USER_INDEX_BUFFERS:
>          case PIPE_CAP_TEXTURE_MULTISAMPLE:
>          case PIPE_CAP_TEXTURE_SWIZZLE:
>          case PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY:
>                  return 1;
>
>                  /* lying for GL 2.0 */
>          case PIPE_CAP_OCCLUSION_QUERY:
>          case PIPE_CAP_POINT_SPRITE:
>                  return 1;
>
> diff --git a/src/gallium/drivers/virgl/virgl_screen.c b/src/gallium/drivers/virgl/virgl_screen.c
> index 49df4f2..6e332d6 100644
> --- a/src/gallium/drivers/virgl/virgl_screen.c
> +++ b/src/gallium/drivers/virgl/virgl_screen.c
> @@ -135,21 +135,20 @@ virgl_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_MIXED_COLORBUFFER_FORMATS:
>        return 1;
>     case PIPE_CAP_GLSL_FEATURE_LEVEL:
>        return vscreen->caps.caps.v1.glsl_level;
>     case PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION:
>        return 0;
>     case PIPE_CAP_COMPUTE:
>        return 0;
>     case PIPE_CAP_USER_VERTEX_BUFFERS:
>        return 0;
> -   case PIPE_CAP_USER_INDEX_BUFFERS:
>     case PIPE_CAP_USER_CONSTANT_BUFFERS:
>        return 1;
>     case PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT:
>        return 16;
>     case PIPE_CAP_STREAM_OUTPUT_PAUSE_RESUME:
>     case PIPE_CAP_STREAM_OUTPUT_INTERLEAVE_BUFFERS:
>        return vscreen->caps.caps.v1.bset.streamout_pause_resume;
>     case PIPE_CAP_START_INSTANCE:
>        return vscreen->caps.caps.v1.bset.start_instance;
>     case PIPE_CAP_TGSI_CAN_COMPACT_CONSTANTS:
> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
> index 1d6d264..7443449 100644
> --- a/src/gallium/include/pipe/p_defines.h
> +++ b/src/gallium/include/pipe/p_defines.h
> @@ -654,21 +654,20 @@ enum pipe_cap
>     PIPE_CAP_TGSI_CAN_COMPACT_CONSTANTS,
>     PIPE_CAP_VERTEX_COLOR_UNCLAMPED,
>     PIPE_CAP_VERTEX_COLOR_CLAMPED,
>     PIPE_CAP_GLSL_FEATURE_LEVEL,
>     PIPE_CAP_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION,
>     PIPE_CAP_USER_VERTEX_BUFFERS,
>     PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY,
>     PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY,
>     PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY,
>     PIPE_CAP_COMPUTE,
> -   PIPE_CAP_USER_INDEX_BUFFERS,
>     PIPE_CAP_USER_CONSTANT_BUFFERS,
>     PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT,
>     PIPE_CAP_START_INSTANCE,
>     PIPE_CAP_QUERY_TIMESTAMP,
>     PIPE_CAP_TEXTURE_MULTISAMPLE,
>     PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT,
>     PIPE_CAP_CUBE_MAP_ARRAY,
>     PIPE_CAP_TEXTURE_BUFFER_OBJECTS,
>     PIPE_CAP_TEXTURE_BUFFER_OFFSET_ALIGNMENT,
>     PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY,
>



More information about the mesa-dev mailing list