[Mesa-dev] [PATCH] radv: fix common extensions getting registered twice.

Dave Airlie airlied at gmail.com
Sun Feb 19 22:20:00 UTC 2017


On 20 February 2017 at 07:06, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl> wrote:
> On Sun, Feb 19, 2017 at 9:56 PM, Dave Airlie <airlied at gmail.com> wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> physical devices can be enumerated multiple time per instance,
>> this was causing the realloc to be hit for no reason, and
>> the CTS allocation verification would get angry.
>
> We only do the radv_physical_device_init on the enumerate with
> instance->physicalDeviceCount < 0 though? We should therefore only
> init the devices once? In that case I don't think this should be
> necessary.

Indeed, I was getting confused, I've tracked down the oom crashes
to a CTS bug in the realloc path, I've sent a fix to khronos.

Thanks,
Dave.


More information about the mesa-dev mailing list