[Mesa-dev] [PATCH] android: define HAVE_DL_ITERATE_PHDR for build-id code

[Tapani Pälli]

On 02/20/2017 11:31 AM, Tapani Pälli wrote:
> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

FYI while this fixes the build errors it seems that there is some issue 
within the code that this enables, I'm getting a segfault within 
dl_iterate_phdr, will investigate why this is.

> On 02/19/2017 12:10 AM, Mauro Rossi wrote:
>> Required due to d4fa083 "util: Add utility build-id code."
>> to avoid following build error and warnings:
>>
>> external/mesa/src/intel/vulkan/anv_device.c:60:32: error: incompatible
>> integer to pointer conversion initializing 'const struct build_id_note
>> *' with an expression of type 'int' [-Werror,-Wint-conversion]
>>    const struct build_id_note *note =
>> build_id_find_nhdr("libvulkan_intel.so");
>>                                ^
>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> external/mesa/src/intel/vulkan/anv_device.c:64:19: warning: implicit
>> declaration of function 'build_id_length' is invalid in C99
>> [-Wimplicit-function-declaration]
>>    unsigned len = build_id_length(note);
>>                   ^
>> external/mesa/src/intel/vulkan/anv_device.c:68:4: warning: implicit
>> declaration of function 'build_id_read' is invalid in C99
>> [-Wimplicit-function-declaration]
>>    build_id_read(note, uuid, VK_UUID_SIZE);
>>    ^
>> 3 warnings and 1 error generated.
>> [ 40% 1438/3588] target  C: libmesa_vulkan_common_32 <=
>> external/mesa/src/intel/vulkan/anv_image.c
>> ninja: build stopped: subcommand failed.
>> build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed
>> make: *** [ninja_wrapper] Error 1
>> ---
>>  Android.common.mk | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Android.common.mk b/Android.common.mk
>> index d01b1b5..c27a77e 100644
>> --- a/Android.common.mk
>> +++ b/Android.common.mk
>> @@ -62,6 +62,7 @@ LOCAL_CFLAGS += \
>>      -DHAVE___BUILTIN_UNREACHABLE \
>>      -DHAVE_PTHREAD=1 \
>>      -DHAVE_DLOPEN \
>> +    -DHAVE_DL_ITERATE_PHDR \
>>      -DTEXTURE_FLOAT_ENABLED \
>>      -fvisibility=hidden \
>>      -Wno-sign-compare
>>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev