[Mesa-dev] [PATCH] isl: add MCS width constraint 16 samples

Jason Ekstrand jason at jlekstrand.net
Mon Feb 20 15:43:20 UTC 2017


On Feb 20, 2017 4:44 AM, "Lionel Landwerlin" <lionel.g.landwerlin at intel.com>
wrote:

Applies on top of Jason's patch :

   https://patchwork.freedesktop.org/patch/139603/

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: Jason Ekstrand <jason at jlekstrand.net>
---
 src/intel/isl/isl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 1a47da5257..3b4579b343 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -1417,6 +1417,9 @@ isl_surf_get_mcs_surf(const struct isl_device *dev,
    assert(surf->levels == 1);
    assert(surf->logical_level0_px.depth == 1);

+   if (ISL_DEV_GEN(dev) == 9 && surf->samples == 16 && surf->width > 8192)


The gen check isn't needed as 16x MSAA isn't supported an any earlier
hardware.  Also, a PRM citation would be good.

+      return false;
+
    enum isl_format mcs_format;
    switch (surf->samples) {
    case 2:  mcs_format = ISL_FORMAT_MCS_2X;  break;
--
2.11.0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170220/8506164e/attachment.html>


More information about the mesa-dev mailing list