[Mesa-dev] [PATCH 00/13] Misc extern C fixes

Emil Velikov emil.l.velikov at gmail.com
Mon Feb 20 17:22:52 UTC 2017


On 20 February 2017 at 16:14, Brian Paul <brianp at vmware.com> wrote:
> On 02/16/2017 08:16 AM, Emil Velikov wrote:
>>
>> Just a bunch of extern C issues flagged by [1]. There's a few more
>> remaining such as the glsl_types C API living in nir_types.{cpp,h} but
>> that can be resolved at a later date.
>>
>> -Emil
>>
>> [1] git grep -B20000 "#.*\<include\>" -- src/ | grep  "\<extern.*\<C\>"
>>
>
> Series, looks OK to me.  Though, one could imagine some .h files that aren't
> included by .cpp sources now being included by .cpp sources in the future.
> So, I'm not sure patches 1, 2, 13 are needed.
>
I thought about that but I doubt we'll need the extern C there anytime
soon. I'll give it a couple days more for people to shout.

> In any case,
> Reviewed-by: Brian Paul <brianp at vmware.com>
>
Thanks !
Emil


More information about the mesa-dev mailing list