[Mesa-dev] [PATCH 4/4] anv: Put everything about queries in genX_query.c

[Jason Ekstrand]

On Mon, Feb 20, 2017 at 10:35 AM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> On 18 February 2017 at 23:59, Jason Ekstrand <jason at jlekstrand.net> wrote:
> > ---
> >  src/intel/vulkan/Makefile.sources  |   5 +-
> >  src/intel/vulkan/anv_query.c       | 171 -------------
> Won't this lead to this [albeit trivial] code built 4 times instead of
> once ? Worth mentioning in the commit message (build time should be
> the same afaict).
>

Yes it would and I did think about that.  I briefly considered just picking
an arbitrary gen and only building the 3 common functions once but I
figured that was probably more hassle than it was worth.


> Regardless, I've verified that nothing sneaked in during the move and
> the makefile changes seem good.
> For 3 and 4:
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>
> -Emil
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170220/ee90220f/attachment.html>