[Mesa-dev] [PATCH mesa 3/8] eglapi: add entrypoint for eglClientWaitSyncKHR
emil.l.velikov at gmail.com
Mon Feb 20 19:36:26 UTC 2017
On 20 February 2017 at 00:03, Eric Engestrom <eric at engestrom.ch> wrote:
> On Sunday, 2017-02-19 18:54:51 -0500, Ilia Mirkin wrote:
>> On Sun, Feb 19, 2017 at 6:51 PM, Eric Engestrom <eric at engestrom.ch> wrote:
>> > On Sunday, 2017-02-19 18:33:16 -0500, Ilia Mirkin wrote:
>> >> Why are patches 1-3 necessary?
>> > They allow patch #4, which makes use of a macro to simplify the list,
>> > (requires a 1:1 mapping of entrypoint to function) which also allows for
>> > the simple sorting test script in patch #7.
>> > I could do without, but honestly I just thought this looked cleaner.
>> I'd rather have a ENTRYPOINT2 macro that allows different external an
>> internal names than duplicating functions. Perhaps others disagree.
> Easy enough to change, I'll do a v2 with that if someone else wants it
> as well :)
>> > Also, I think the debug extension would print the wrong function names
>> > before these patches? Not tested though, maybe it somehow worked.
>> Is that important?
> Probably not, which is why I didn't mention it at first.
Fwiw I'm in favour of 1-3. The extra 35 LoC is nothing - we already
have the *Common pattern throughout eglapi.c.
More information about the mesa-dev