[Mesa-dev] [PATCH] gallium: reorder fields in pipe_draw_info

Marek Olšák maraeo at gmail.com
Mon Feb 20 19:57:57 UTC 2017


On Mon, Feb 20, 2017 at 8:36 PM, Roland Scheidegger <sroland at vmware.com> wrote:
> Am 20.02.2017 um 20:08 schrieb Marek Olšák:
>> On Mon, Feb 20, 2017 at 8:03 PM, Roland Scheidegger <sroland at vmware.com> wrote:
>>> This doesn't quite just do what the commit log says, since at least one
>>> parameter is changed from unsigned to ubyte (I hope vertices_per_patch
>>> can't exceed that for any driver...)
>>
>> vertices_per_patch must be in [1, 32]. Only 5 bits are necessary to
>> represent it.
>
> Well as far as I can tell at a very quick glance this is an
> implementation dependent limit.
> But I don't have any objections making it a ubyte if no implementations
> could handle more than 32 (or even 64, 128,...) anyway (should just
> mention it in the log that it's changed to ubyte).

Yeah, I've already updated the commit message.

Marek


More information about the mesa-dev mailing list