[Mesa-dev] [PATCH 3/4] gallium: add disk_cache_create() callback

[Nicolai Hähnle]

On 20.02.2017 01:15, Timothy Arceri wrote:
> ---
>  src/gallium/include/pipe/p_screen.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h
> index b6203f1..43dcdf0 100644
> --- a/src/gallium/include/pipe/p_screen.h
> +++ b/src/gallium/include/pipe/p_screen.h
> @@ -58,6 +58,7 @@ struct pipe_surface;
>  struct pipe_transfer;
>  struct pipe_box;
>  struct pipe_memory_info;
> +struct disk_cache;
>
>
>  /**
> @@ -318,6 +319,11 @@ struct pipe_screen {
>     const void *(*get_compiler_options)(struct pipe_screen *screen,
>                                        enum pipe_shader_ir ir,
>                                        unsigned shader);
> +
> +   /**
> +    * Returns pointer to drivers on-disk shader cache.

"the driver's"? Is it allowed to return NULL?

This should probably have some minimal documentation in screen.rst, as 
well as the various pass-throughs (ddebug, rbug, trace).

Thanks,
Nicolai

> +    */
> +   struct disk_cache *(*get_disk_shader_cache)(struct pipe_screen *screen);
>  };
>
>
>