[Mesa-dev] [PATCH 1/2] st/vdpau: Don't reallocate video surfaces on putBitsYCbCr format mismatch

Thomas Hellstrom thellstrom at vmware.com
Wed Feb 22 14:06:32 UTC 2017


On 02/22/2017 03:00 PM, Christian K├Ânig wrote:
> Am 22.02.2017 um 14:42 schrieb Thomas Hellstrom:
>> mplayer likes putting YV12 data, and if there is a buffer format
>> mismatch,
>> the vdpau state tracker would try to reallocate the video surface as an
>> YV12 surface. A virtual driver doesn't like reallocating and doesn't
>> like YV12
>> surfaces, so before trying the reallocation, check whether we can
>> instead do
>> an YV12 to NV12 format conversion.
>>
>> Also advertize that we actually can do the getBits and putBits
>> conversion.
>>
>> Signed-off-by: Thomas Hellstrom <thellstrom at vmware.com>
>> Reviewed-by: Sinclair Yeh <syeh at vmware.com>
>
> NAK, the internal format of the surfaces should follow what the
> application has put into it as much as possible. That has quite some
> performance advantages.
>
> You should only do the conversation if the backend driver can't handle
> the desired format.
>
> Regards,
> Christian. 

OK. I'll respin.

/Thomas



More information about the mesa-dev mailing list